diff --git a/pumpkin-core/src/text/hover.rs b/pumpkin-core/src/text/hover.rs index f01d8f30b..d9651fa4b 100644 --- a/pumpkin-core/src/text/hover.rs +++ b/pumpkin-core/src/text/hover.rs @@ -6,7 +6,6 @@ use super::Text; #[derive(Clone, Debug, Serialize, Deserialize)] #[serde(tag = "action", content = "contents", rename_all = "snake_case")] -#[allow(clippy::enum_variant_names)] pub enum HoverEvent<'a> { /// Displays a tooltip with the given text. ShowText(Text<'a>), diff --git a/pumpkin-inventory/src/player.rs b/pumpkin-inventory/src/player.rs index fd92220a9..3aa5963a7 100644 --- a/pumpkin-inventory/src/player.rs +++ b/pumpkin-inventory/src/player.rs @@ -1,6 +1,5 @@ use pumpkin_world::item::Item; -#[allow(dead_code)] pub struct PlayerInventory { // Main Inventory + Hotbar crafting: [Option; 4], diff --git a/pumpkin-protocol/src/packet_encoder.rs b/pumpkin-protocol/src/packet_encoder.rs index 511d095d2..36b9c3697 100644 --- a/pumpkin-protocol/src/packet_encoder.rs +++ b/pumpkin-protocol/src/packet_encoder.rs @@ -22,8 +22,6 @@ pub struct PacketEncoder { } impl PacketEncoder { - // i think clippy is broken - #[allow(clippy::needless_borrows_for_generic_args)] pub fn append_packet(&mut self, packet: &P) -> Result<(), PacketError> { let start_len = self.buf.len(); @@ -87,6 +85,7 @@ impl PacketEncoder { let mut front = &mut self.buf[start_len..]; + #[allow(clippy::needless_borrows_for_generic_args)] VarInt(packet_len as i32) .encode(&mut front) .map_err(|_| PacketError::EncodeLength)?; diff --git a/pumpkin-protocol/src/slot.rs b/pumpkin-protocol/src/slot.rs index 2ccab79b9..58386bbe2 100644 --- a/pumpkin-protocol/src/slot.rs +++ b/pumpkin-protocol/src/slot.rs @@ -7,7 +7,6 @@ use serde::{ }; #[derive(Debug, Clone)] -#[allow(dead_code)] pub struct Slot { item_count: VarInt, item_id: Option, diff --git a/pumpkin-world/src/global_registry.rs b/pumpkin-world/src/global_registry.rs index 1723cb8f8..19f8a6e6f 100644 --- a/pumpkin-world/src/global_registry.rs +++ b/pumpkin-world/src/global_registry.rs @@ -24,7 +24,6 @@ pub fn get_protocol_id(category: &str, entry: &str) -> u32 { .expect("No Entry found") } -#[allow(dead_code)] pub fn get_default<'a>(category: &str) -> Option<&'a str> { REGISTRY .get(category) diff --git a/pumpkin-world/src/world_gen/generator.rs b/pumpkin-world/src/world_gen/generator.rs index 75ec90838..d74949e00 100644 --- a/pumpkin-world/src/world_gen/generator.rs +++ b/pumpkin-world/src/world_gen/generator.rs @@ -12,7 +12,6 @@ pub trait GeneratorInit { } pub trait WorldGenerator: Sync + Send { - #[allow(dead_code)] fn generate_chunk(&self, at: Vector2) -> ChunkData; } assert_obj_safe! {WorldGenerator} diff --git a/pumpkin-world/src/world_gen/implementations/superflat.rs b/pumpkin-world/src/world_gen/implementations/superflat.rs index edbbcf4ba..9d0e57efd 100644 --- a/pumpkin-world/src/world_gen/implementations/superflat.rs +++ b/pumpkin-world/src/world_gen/implementations/superflat.rs @@ -9,7 +9,6 @@ use crate::{ }, }; -#[allow(dead_code)] pub type SuperflatGenerator = GenericGenerator; pub(crate) struct SuperflatBiomeGenerator {} diff --git a/pumpkin-world/src/world_gen/mod.rs b/pumpkin-world/src/world_gen/mod.rs index 9ab676e24..fd0692bdd 100644 --- a/pumpkin-world/src/world_gen/mod.rs +++ b/pumpkin-world/src/world_gen/mod.rs @@ -9,7 +9,6 @@ pub use seed::Seed; use generator::GeneratorInit; use implementations::superflat::SuperflatGenerator; -#[allow(dead_code)] pub fn get_world_gen(seed: Seed) -> Box { // TODO decide which WorldGenerator to pick based on config. Box::new(SuperflatGenerator::new(seed)) diff --git a/pumpkin/src/client/authentication.rs b/pumpkin/src/client/authentication.rs index 692cf266c..0f1fc1e73 100644 --- a/pumpkin/src/client/authentication.rs +++ b/pumpkin/src/client/authentication.rs @@ -24,7 +24,6 @@ pub struct ProfileTextures { } #[derive(Deserialize, Clone, Debug)] -#[allow(non_snake_case)] #[allow(dead_code)] pub struct Texture { url: String, diff --git a/pumpkin/src/commands/tree.rs b/pumpkin/src/commands/tree.rs index eb0647826..63243be59 100644 --- a/pumpkin/src/commands/tree.rs +++ b/pumpkin/src/commands/tree.rs @@ -23,8 +23,9 @@ pub(crate) enum NodeType<'a> { run: &'a (dyn Fn(&mut CommandSender, &mut Server, &ConsumedArgs) -> Result<(), InvalidTreeError> + Sync), }, - #[allow(dead_code)] // todo: remove (so far no commands requiring this are implemented) - Literal { string: &'a str }, + Literal { + string: &'a str, + }, Argument { name: &'a str, consumer: ArgumentConsumer<'a>, diff --git a/pumpkin/src/main.rs b/pumpkin/src/main.rs index 18bc812b0..d7cc89e62 100644 --- a/pumpkin/src/main.rs +++ b/pumpkin/src/main.rs @@ -1,4 +1,3 @@ -#![allow(clippy::await_holding_refcell_ref)] #![allow(clippy::await_holding_lock)] #[cfg(target_os = "wasi")]