use get_state_id instead of get_state when loading Chunks

pumpkin-world/src/block/mod.rs

@@ -10,6 +10,8 @@ use pumpkin_data::{
 use serde::{Deserialize, Deserializer, Serialize, Serializer};
 pub use state::RawBlockState;
 
+use crate::BlockStateId;
+
 #[derive(Serialize, Deserialize, Debug, Clone)]
 #[serde(rename_all = "PascalCase")]
 pub struct BlockStateCodec {
@@ -42,6 +44,12 @@ where
 
 impl BlockStateCodec {
     pub fn get_state(&self) -> Option<&'static BlockState> {
+        let state_id = self.get_state_id();
+        get_state_by_state_id(state_id)
+    }
+
+    /// Prefer this over `get_state` when the only the state ID is needed
+    pub fn get_state_id(&self) -> BlockStateId {
         let block = self.name;
 
         let mut state_id = block.default_state.id;
@@ -54,8 +62,7 @@ impl BlockStateCodec {
             let block_properties = block.from_properties(props).unwrap();
             state_id = block_properties.to_state_id(block);
         }
-
-        get_state_by_state_id(state_id)
+        state_id
     }
 }
 

pumpkin-world/src/chunk/palette.rs

@@ -298,7 +298,7 @@ impl BiomePalette {
 
         Self::from_palette_and_packed_data(
             &palette,
-            nbt.data.as_ref().unwrap_or(&vec![].into_boxed_slice()),
+            nbt.data.as_ref().unwrap_or(&Box::default()),
             BIOME_DISK_MIN_BITS,
         )
     }
@@ -398,22 +398,12 @@ impl BlockPalette {
         let palette = nbt
             .palette
             .into_iter()
-            .map(|entry| {
-                if let Some(block_state) = entry.get_state() {
-                    block_state.id
-                } else {
-                    log::warn!(
-                        "Could not find valid block state for {}. Defaulting...",
-                        entry.name.name
-                    );
-                    0
-                }
-            })
+            .map(|entry| entry.get_state_id())
             .collect::<Vec<_>>();
 
         Self::from_palette_and_packed_data(
             &palette,
-            nbt.data.as_ref().unwrap_or(&vec![].into_boxed_slice()),
+            nbt.data.as_ref().unwrap_or(&Box::default()),
             BLOCK_DISK_MIN_BITS,
         )
     }

pumpkin-world/src/generation/proto_chunk.rs

@@ -138,7 +138,8 @@ impl<'a> ProtoChunk<'a> {
         let sampler = FluidLevelSampler::Chunk(Box::new(StandardChunkFluidLevelSampler::new(
             FluidLevel::new(
                 settings.sea_level,
-                settings.default_fluid.get_state().unwrap().block(),
+                // Block
+                settings.default_fluid.name,
             ),
             FluidLevel::new(-54, &LAVA_BLOCK), // this is always the same for every dimension
         )));

pumpkin-world/src/generation/rule/random_block_state_match.rs

@@ -12,6 +12,6 @@ pub struct RandomBlockStateMatchRuleTest {
 
 impl RandomBlockStateMatchRuleTest {
     pub fn test(&self, state: &BlockState, random: &mut RandomGenerator) -> bool {
-        state.id == self.block_state.get_state().unwrap().id && random.next_f32() < self.probability
+        state.id == self.block_state.get_state_id() && random.next_f32() < self.probability
     }
 }