Pumpkin-MC/Pumpkin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: https://github.com/Pumpkin-MC/Pumpkin/issues/2424

Browse Source
This commit is contained in:
Alexander Medvedev 2026-07-20 11:42:20 +02:00
parent f4815f5c78
commit afbe839dea
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pumpkin-protocol/src/java/client/play/update_advancement.rs
View File

@ -1,3 +1,4 @@
use crate::codec::item_stack_seralizer::ItemStackTemplateSerializer;
use crate::codec::var_int::VarInt; use crate::codec::var_int::VarInt;
use pumpkin_data::Advancement; use pumpkin_data::Advancement;
use pumpkin_data::advancement_data::AdvancementProgressData; use pumpkin_data::advancement_data::AdvancementProgressData;
@ -44,7 +45,7 @@ impl ClientPacket for CUpdateAdvancements {
fn write_packet_data( fn write_packet_data(
&self, &self,
mut write: impl std::io::Write, mut write: impl std::io::Write,
_version: &JavaMinecraftVersion, version: &JavaMinecraftVersion,
) -> Result<(), crate::ser::WritingError> { ) -> Result<(), crate::ser::WritingError> {
write.write_bool(self.reset)?; write.write_bool(self.reset)?;
@ -65,10 +66,9 @@ impl ClientPacket for CUpdateAdvancements {
write.write_slice(&display.get_description().encode())?; write.write_slice(&display.get_description().encode())?;
// Item icon // Item icon
// TODO: serialize item_icon (ItemStack) ItemStackTemplateSerializer::from(display.item_icon.clone())
unimplemented!("Item serialization is not yet implemented without serde"); .write_with_version(&mut write, version)?;
/*
write.write_var_int(&VarInt(display.frame_type as i32))?; write.write_var_int(&VarInt(display.frame_type as i32))?;
let flags = (display.has_background() as i32) let flags = (display.has_background() as i32)
| ((display.show_toast as i32) << 1) | ((display.show_toast as i32) << 1)
@ -79,7 +79,6 @@ impl ClientPacket for CUpdateAdvancements {
} }
write.write_f32_be(display.x)?; write.write_f32_be(display.x)?;
write.write_f32_be(display.y)?; write.write_f32_be(display.y)?;
*/
} }
write.write_var_int(&VarInt(adv.requirements.len() as i32))?; write.write_var_int(&VarInt(adv.requirements.len() as i32))?;

4
pumpkin-protocol/src/lib.rs
View File

@ -401,9 +401,9 @@ impl NumberFormat {
// TODO: Style write // TODO: Style write
Ok(()) Ok(())
} }
Self::Fixed(_text) => { Self::Fixed(text) => {
write.write_var_int(&2.into())?; write.write_var_int(&2.into())?;
// TODO: TextComponent write write.write_slice(&text.encode())?;
Ok(()) Ok(())
} }
} }