From 3c7106af0b3e7ceb95e967174ea38ffa16e304cb Mon Sep 17 00:00:00 2001
From: Snowiiii <lilalexmed@proton.me>
Date: Mon, 4 Nov 2024 21:48:28 +0100
Subject: [PATCH] Print raw Packet ID when not found

We now will use Raw Packet IDs instead of hex
---
 pumpkin/src/client/mod.rs       | 6 +++---
 pumpkin/src/entity/player.rs    | 2 +-
 pumpkin/src/world/scoreboard.rs | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/pumpkin/src/client/mod.rs b/pumpkin/src/client/mod.rs
index 73379cd03..83a812a6c 100644
--- a/pumpkin/src/client/mod.rs
+++ b/pumpkin/src/client/mod.rs
@@ -400,7 +400,7 @@ impl Client {
             }
             _ => {
                 log::error!(
-                    "Failed to handle client packet id {:#04x} in Status State",
+                    "Failed to handle client packet id {} in Status State",
                     packet.id.0
                 );
                 return Err(DeserializerError::UnknownPacket);
@@ -435,7 +435,7 @@ impl Client {
             }
             _ => {
                 log::error!(
-                    "Failed to handle client packet id {:#04x} in Login State",
+                    "Failed to handle client packet id {} in Login State",
                     packet.id.0
                 );
                 return Ok(());
@@ -469,7 +469,7 @@ impl Client {
             }
             _ => {
                 log::error!(
-                    "Failed to handle client packet id {:#04x} in Config State",
+                    "Failed to handle client packet id {} in Config State",
                     packet.id.0
                 );
                 return Err(DeserializerError::UnknownPacket);
diff --git a/pumpkin/src/entity/player.rs b/pumpkin/src/entity/player.rs
index 7e8f0854a..b96a77e57 100644
--- a/pumpkin/src/entity/player.rs
+++ b/pumpkin/src/entity/player.rs
@@ -722,7 +722,7 @@ impl Player {
             }
             SUseItem::PACKET_ID => self.handle_use_item(&SUseItem::read(bytebuf)?),
             _ => {
-                log::warn!("Failed to handle player packet id {:#04x}", packet.id.0);
+                log::warn!("Failed to handle player packet id {}", packet.id.0);
                 // TODO: We give an error if all play packets are implemented
                 //  return Err(Box::new(DeserializerError::UnknownPacket));
             }
diff --git a/pumpkin/src/world/scoreboard.rs b/pumpkin/src/world/scoreboard.rs
index 561b4097b..61279eed4 100644
--- a/pumpkin/src/world/scoreboard.rs
+++ b/pumpkin/src/world/scoreboard.rs
@@ -43,7 +43,7 @@ impl Scoreboard {
         world
             .broadcast_packet_all(&CDisplayObjective::new(
                 pumpkin_protocol::client::play::DisplaySlot::Sidebar,
-                "test",
+                objective.name,
             ))
             .await;
     }