From 286253cdc688429d68549bc6cf6c9246d9cb6840 Mon Sep 17 00:00:00 2001
From: StripedMonkey <monkeyinastripedshirt@gmail.com>
Date: Tue, 3 Sep 2024 19:30:10 -0400
Subject: [PATCH] eliminate unnecessary (and overloaded) variable

---
 pumpkin/src/main.rs | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/pumpkin/src/main.rs b/pumpkin/src/main.rs
index a0e76eeab..18bc812b0 100644
--- a/pumpkin/src/main.rs
+++ b/pumpkin/src/main.rs
@@ -156,25 +156,22 @@ fn main() -> io::Result<()> {
 
                     token => {
                         // Poll Players
-                        let done = if let Some(player) = players.get_mut(&token) {
+                        if let Some(player) = players.get_mut(&token) {
                             let mut player = player.lock().unwrap();
                             player.client.poll(event).await;
                             if !player.client.closed {
                                 let mut server = server.lock().await;
                                 player.process_packets(&mut server).await;
                             }
-                            player.client.closed
-                        } else {
-                            false
-                        };
-
-                        if done {
-                            if let Some(player) = players.remove(&token) {
-                                let mut player = player.lock().unwrap();
-                                player.remove().await;
-                                poll.registry().deregister(&mut player.client.connection)?;
+                            if player.client.closed {
+                                drop(player);
+                                if let Some(player) = players.remove(&token) {
+                                    let mut player = player.lock().unwrap();
+                                    player.remove().await;
+                                    poll.registry().deregister(&mut player.client.connection)?;
+                                }
                             }
-                        }
+                        };
 
                         // Poll current Clients (non players)
                         // Maybe received an event for a TCP connection.